Matthias Clasen [Sat, 2 Aug 2014 23:28:23 +0000 (01:28 +0200)]
inspector: Add GtkTreeSelection to the object tree
It is not accessible, otherwise.
Carlos Garnacho [Fri, 1 Aug 2014 14:50:59 +0000 (16:50 +0200)]
window: Only avoid queueing resizes if the popover position didn't change
If the same position is requested on a popover, it should at least ensure
the window is realized and raised, even if no resizes are queued on the
content. Otherwise other widgets being mapped might raise the windows over
the popover's if its original position is unchanged.
https://bugzilla.gnome.org/show_bug.cgi?id=734129
Jasper St. Pierre [Thu, 31 Jul 2014 16:27:46 +0000 (18:27 +0200)]
gtkcssshadowvalue: Don't double-apply the alpha to shadows
It turns out that when we were painting the shadows, we painted the them
with the base color once, which contained the alpha, and then blurred it
and used it as a mask for the fill, which has the fill again.
To fix this, always paint the base surface with full alpha. The existing
code applies the blur conditionally sometimes in weird ways, so the code
shuffling fix may not look correct, but be assured it is. If the blur
happens, the new cr we return has the *default* color applied, which is
fully opaque black, which works perfectly against the A8 surface.
The fallback spinner code needs some modification, since it is
intentionally using the alpha to paint the lobes which are "in the past".
Since we shouldn't be hitting this fallback path very often, we use a
temporary group and paint it with paint_with_alpha, even though it is
slow.
Matthias Clasen [Sat, 2 Aug 2014 22:42:48 +0000 (00:42 +0200)]
Small comment fixups
One factual pointed out in the review in
https://bugzilla.gnome.org/show_bug.cgi?id=734053, plus some
formatting nit picks.
Jasper St. Pierre [Wed, 30 Jul 2014 10:26:08 +0000 (12:26 +0200)]
gtkcairoblur: Replace our exponential blur with the box blur from mutter
https://bugzilla.gnome.org/show_bug.cgi?id=734053
Matthias Clasen [Sat, 2 Aug 2014 22:23:58 +0000 (00:23 +0200)]
Add the new debug option to the docs
All debug options are supposed to be listed in the "Running and
Debugging" section of the docs.
Ryan Lortie [Wed, 30 Jul 2014 10:28:21 +0000 (12:28 +0200)]
GtkMenuTrackerItem: introduce action debugging
Add some action debugging output for GtkMenuTrackerItem as well...
https://bugzilla.gnome.org/show_bug.cgi?id=733965
Ryan Lortie [Wed, 30 Jul 2014 10:00:55 +0000 (12:00 +0200)]
GtkActionHelper: add some debugging output
Introduce a new debug category "actions" and write some messages from
GtkActionHelper about if we can find the actions or not.
We will probably soon want to add some similar messages to
GtkMenuTrackerItem.
https://bugzilla.gnome.org/show_bug.cgi?id=733965
Matthias Clasen [Sat, 2 Aug 2014 20:04:14 +0000 (22:04 +0200)]
Remove a reference to a non-existing function
Руслан Ижбулатов [Fri, 25 Jul 2014 23:28:31 +0000 (23:28 +0000)]
W32: Don't crash when opacity is set for non-toplevel
X11 backend doesn't, and for good reason - main code body does not check
that the window it sets opacity for is, in fact, toplevel.
Just silently fail to do anything for non-toplevel windows.
https://bugzilla.gnome.org/show_bug.cgi?id=733769
Руслан Ижбулатов [Sat, 2 Aug 2014 05:16:09 +0000 (05:16 +0000)]
Use g_clear_object() shorthand for unref-and-set-to-null
https://bugzilla.gnome.org/show_bug.cgi?id=733766
Руслан Ижбулатов [Fri, 25 Jul 2014 23:30:20 +0000 (23:30 +0000)]
W32: Don't unregister parent window of an embedded widget
This leads to an assertion failure, because parent window is never registered
in the first place, widget's own GdkWindow is. But that window is unregistered
in a generic fashion by GtkWidget code, so there's nothing for us to do here.
https://bugzilla.gnome.org/show_bug.cgi?id=733766
Руслан Ижбулатов [Fri, 1 Aug 2014 14:02:13 +0000 (14:02 +0000)]
Remove generated gtk-win32.rc from EXTRA_DIST
https://bugzilla.gnome.org/show_bug.cgi?id=733773
Matthias Clasen [Sat, 2 Aug 2014 11:53:04 +0000 (13:53 +0200)]
icon-browser: Redo the icon categorization
Instead of slavishly following the naming spec, group the icons
into categories that are more likely to be useful for application
developers. Based on input from Allan Day and Jakup Steiner.
Matthias Clasen [Sat, 2 Aug 2014 11:55:44 +0000 (13:55 +0200)]
icon-browser: Show category descriptions as tooltips
No better place for them right now.
Matthias Clasen [Fri, 1 Aug 2014 23:18:57 +0000 (01:18 +0200)]
Set initial focus in some dialog tests
Use the new <initial-focus> element here to confirm that it is
parsed properly and works as expected.
Matthias Clasen [Sat, 2 Aug 2014 09:35:34 +0000 (11:35 +0200)]
GtkWindow: Add a way to declare initial focus in ui files
With this commit, it is possible to use <initial-focus name="blah">
to declare the initial focus widget for a window.
This is related to
https://bugzilla.gnome.org/show_bug.cgi?id=734033
Matthias Clasen [Sat, 2 Aug 2014 09:17:18 +0000 (11:17 +0200)]
Add a test for window focus handling
This is a small test that checks that gtk_window_set/get_focus
behave as expected, regardless of the window being shown or hidden.
Matthias Clasen [Sat, 2 Aug 2014 09:28:03 +0000 (11:28 +0200)]
GtkWindow: Make set_focus work before show
So far, gtk_window_set_focus just did not work when called on
a hidden window. Change it to record the desired focus widget
for hidden windows, and apply it when the window gets shown.
This is similar to how we tread other window properties that
can't be set before the window is realized, like maximized
or fullscreen.
This is related to
https://bugzilla.gnome.org/show_bug.cgi?id=734033
Руслан Ижбулатов [Fri, 25 Jul 2014 23:33:06 +0000 (23:33 +0000)]
Ensure that print operation is alive until we're done
https://bugzilla.gnome.org/show_bug.cgi?id=733767
Khaled Hosny [Fri, 1 Aug 2014 00:01:12 +0000 (03:01 +0300)]
Update Arabic translation
Sébastien Wilmet [Thu, 31 Jul 2014 12:11:49 +0000 (14:11 +0200)]
textiter: don't call g_utf8_prev_char() on start of string
Changes also the "goto finally" with a break. A break is more common.
Another way is to use g_utf8_find_prev_char().
https://bugzilla.gnome.org/show_bug.cgi?id=638709
Piotr Drąg [Thu, 31 Jul 2014 15:52:35 +0000 (17:52 +0200)]
Updated POTFILES.skip
Benjamin Otte [Thu, 31 Jul 2014 14:10:17 +0000 (16:10 +0200)]
label: Don't clip text shadows
The previous code for computing the clip rectangle forgot to respect
the text-shadow CSS property. This is usually not very visible because
text shadows usually don't extend the ink rectangle by very much.
See attached testcase for an example.
Руслан Ижбулатов [Thu, 31 Jul 2014 14:03:00 +0000 (14:03 +0000)]
GDK W32: add environment variable to override system font scaling
Support environment variable GDK_WIN32_FONT_RESOLUTION that can be set to
a desired dpi (72, 96, 130, etc) to override system settings. Useful for
debugging, since changing system font scaling requires the user to log off
and log on again.
https://bugzilla.gnome.org/show_bug.cgi?id=734038
Руслан Ижбулатов [Thu, 31 Jul 2014 14:01:56 +0000 (14:01 +0000)]
GDK W32: support font scaling
Respect system font scaling (Control Panel -> Display -> Font Size) and
convey that information to GDK (which then passes it to Pango).
https://bugzilla.gnome.org/show_bug.cgi?id=734038
Benjamin Otte [Wed, 30 Jul 2014 16:45:15 +0000 (18:45 +0200)]
css: Fail animation shorthand parsing properly
When a number is not a nubmer, don't just crash, exit properly with an
error code.
See attached testcase for an example.
Benjamin Otte [Wed, 30 Jul 2014 16:23:20 +0000 (18:23 +0200)]
css: Don't infloop when parsing broken borders
There was an infinite loop when parsing invalid text after having parsed
a color in the border shorthand. See attached testcase for an example.
Matthias Clasen [Wed, 30 Jul 2014 22:12:30 +0000 (00:12 +0200)]
GtkImage: Always close the loader
This was causing some tests to fail with a critical.
Matthias Clasen [Wed, 30 Jul 2014 21:46:13 +0000 (23:46 +0200)]
inspector: Make the action editor more useful
We were not finding the action owner for menuitems, we have to
try harder to walk all the way up to the window.
Matthias Clasen [Wed, 30 Jul 2014 21:11:17 +0000 (23:11 +0200)]
Add a test for popover accessible parents
This tests the fix in the previous commit.
Matthias Clasen [Wed, 30 Jul 2014 21:09:51 +0000 (23:09 +0200)]
GtkPopover: Properly update a11y parent
When the relative-to widget changes, update the accessible parent
of the popovers accessible.
https://bugzilla.gnome.org/show_bug.cgi?id=733923
Olav Vitters [Wed, 30 Jul 2014 13:53:33 +0000 (15:53 +0200)]
doap category core
Ryan Lortie [Tue, 29 Jul 2014 15:29:09 +0000 (17:29 +0200)]
GtkApplication: load gtk/menus-common.ui resource
Allow the app to install a resource called gtk/menus-common.ui which
will always be loaded, regardless of which type of menus we are using.
https://bugzilla.gnome.org/show_bug.cgi?id=733925
Sébastien Wilmet [Sun, 20 Jul 2014 13:44:12 +0000 (15:44 +0200)]
textbuffer: emit notify signal for the "text" property
Although there is the "changed" signal, it is more correct to notify the
"text" property too. It can be useful for a small text view, where the
text is saved e.g. to gsettings with a binding to the text property.
The "text" property includes only the text, not child widgets or images,
so the notify signal is sent too many times (also for child widgets and
images), but it's not a big problem.
https://bugzilla.gnome.org/show_bug.cgi?id=624791
Matthias Clasen [Tue, 29 Jul 2014 12:57:28 +0000 (14:57 +0200)]
icon-browser: Hide the description label when empty
Matthias Clasen [Tue, 29 Jul 2014 12:50:10 +0000 (14:50 +0200)]
icon-browser: Don't crash on exit
Matthias Clasen [Tue, 29 Jul 2014 12:07:54 +0000 (14:07 +0200)]
icon-browser: Don't show empty categories
We don't have any icons in International, so don't show the
category. And process-working is really just a theme asset,
so don't show that either.
Matthias Clasen [Tue, 29 Jul 2014 12:03:48 +0000 (14:03 +0200)]
icon-browser: Make the cell renderer follow state
This is very useful for symbolic icons.
Matthias Clasen [Tue, 29 Jul 2014 12:01:15 +0000 (14:01 +0200)]
icon-browser: Hide the search icon until it works
Matthias Clasen [Tue, 29 Jul 2014 11:38:54 +0000 (13:38 +0200)]
inspector: Set a filename for saving css
This is good practice when using save dialogs.
Matthias Clasen [Sun, 27 Jul 2014 11:44:41 +0000 (13:44 +0200)]
wip: more icon browser rework
Matthias Clasen [Sun, 27 Jul 2014 07:32:10 +0000 (09:32 +0200)]
wip: rework icon browser
Jasper St. Pierre [Mon, 28 Jul 2014 20:04:05 +0000 (22:04 +0200)]
gtkcairoblur: Blur a CAIRO_A8 surface instead of a full CAIRO_ARGB32
This is considerably faster to draw and paint.
Jasper St. Pierre [Mon, 28 Jul 2014 20:04:09 +0000 (22:04 +0200)]
gtkcssshadowvalue: Use the blur surface as a mask, instead of painting it
This will make it easier to use an A8 for our blurred surface instead of
a ARGB32, which makes things a lot easier and faster.
Cosimo Cecchi [Wed, 23 Jul 2014 04:27:59 +0000 (21:27 -0700)]
iconhelper: reset original pixbuf scale on clear
Avoids a previously set value for a different image to accidentally
stick around.
https://bugzilla.gnome.org/show_bug.cgi?id=733416
Cosimo Cecchi [Sat, 19 Jul 2014 20:03:58 +0000 (13:03 -0700)]
image: support scale factor when loading from GResource and file
Currently, when loading an image from a GResource or file we don't take
the scale factor of the display into consideration, and let
GtkIconHelper scale it accordingly.
While this in general works for non-scalable images, we can take
advantage of the native loader's scaling for e.g. SVG images, and load
them at the right scale factor automatically.
This is achieved by switching to a pixbuf loader instead of using the
native function.
https://bugzilla.gnome.org/show_bug.cgi?id=733416
Руслан Ижбулатов [Thu, 24 Jul 2014 16:27:09 +0000 (16:27 +0000)]
W32: Implement rudimentary WM_NCHITTEST handling
Use (cairo) input shape of the window to check whether a point is inside or not
inside the window.
If it is, let the default window procedure do its thing (which seems to be
working all right in all known cases).
If it isn't, override the default window procedure and tell WM what we think.
Don't do any of the above if the window has CSD-incompatible styles (WS_BORDER
or WS_THICKFRAME).
This is a crude kind of substitute for window input shape support (which W32
does not seem to have). Still probably enough to be positive about input shapes
support.
https://bugzilla.gnome.org/show_bug.cgi?id=733679
Alexander Larsson [Mon, 28 Jul 2014 19:19:31 +0000 (21:19 +0200)]
Update testtextview.c to use draw_layer
This fixes a regression in the test from the revert in
commit
4fe051bb4a017d2840f2b0f4299512971f17a837.
Alexander Larsson [Mon, 28 Jul 2014 13:20:52 +0000 (15:20 +0200)]
textview: Add draw_layer vfunc
This allows subclasses to render things below and above the text
in the text view. This allows e.g. GtkSourceView to highlight the
cursor row and to render overlays for colum 80. This used to be done
by rendering before/after chaining up to the parent, but that doesn't
work anymore since the view now renders a background, and due to the
use of the pixel cache.
Alexander Larsson [Sun, 27 Jul 2014 13:41:01 +0000 (15:41 +0200)]
Revert "GtkTextView: Fix regression in GtkSourceView drawing"
This reverts commit
1ac13435b7c14dd9b97ad7a9d292acd51337d66e.
We want to instead replace this with special vfunc for drawing
below/above the main text so that gtksourceview can use it.
Lapo Calamandrei [Mon, 28 Jul 2014 13:34:03 +0000 (15:34 +0200)]
Adwaita: fix a typo
Lapo Calamandrei [Mon, 28 Jul 2014 10:42:23 +0000 (12:42 +0200)]
Adwaita: button drawing function rework...
...to take colored buttons into considerations, so buttons on
colored background works better now (infobars and the like).
Paolo Borelli [Mon, 28 Jul 2014 10:20:48 +0000 (12:20 +0200)]
textview: document text mark properties
Georges Neto [Mon, 28 Jul 2014 04:27:57 +0000 (04:27 +0000)]
Updated Brazilian Portuguese translation
Jakub Steiner [Sun, 27 Jul 2014 11:39:02 +0000 (13:39 +0200)]
Adwaita: remove shadows from progressbars
Aurimas Černius [Sat, 26 Jul 2014 21:48:53 +0000 (00:48 +0300)]
Updated Lithuanian properties translation
Jasper St. Pierre [Sat, 26 Jul 2014 13:46:56 +0000 (09:46 -0400)]
gdkdevice-wayland: Fix compile warnings
These are signed, not unsigned.
Matthias Clasen [Fri, 25 Jul 2014 18:41:55 +0000 (14:41 -0400)]
icon-browser: Add open-menu to the list
Jasper St. Pierre [Fri, 25 Jul 2014 13:37:06 +0000 (09:37 -0400)]
wayland-device: Upgrade to v4 of seat
Get our keyboard repeat info from the server.
Jasper St. Pierre [Fri, 25 Jul 2014 13:41:48 +0000 (09:41 -0400)]
wayland-device: Upgrade to v3 of seat
To prevent memory leaks.
Jasper St. Pierre [Fri, 25 Jul 2014 13:38:22 +0000 (09:38 -0400)]
wayland-device: Handle v2 of seat
Jasper St. Pierre [Fri, 25 Jul 2014 13:32:55 +0000 (09:32 -0400)]
wayland-device: Refactor a bit
Delay the keyboard settings creation until we're delivering the key
press. This means we don't have to create the settings for a server that
sends us repeat information.
Jasper St. Pierre [Fri, 25 Jul 2014 13:27:22 +0000 (09:27 -0400)]
wayland-device: Reindent
Alejandro Piñeiro [Wed, 23 Jul 2014 15:56:59 +0000 (17:56 +0200)]
a11y: unref selected item only if it is not NULL
https://bugzilla.gnome.org/show_bug.cgi?id=733610
Руслан Ижбулатов [Thu, 24 Jul 2014 13:41:51 +0000 (13:41 +0000)]
Remove gdk_win32_input_shape_combine_region()
This function currently calls gdk_win32_window_shape_combine_region(),
which is wrong, because it leads to SetWindowRgn() being called with
non-NULL region, which makes W32 disable theming (particularly - decoration
theming), which makes decorations revert back to old GDI-drawn Windows 2000
variant, which looks out of place and interacts *badly* with alpha channel
(because GDI).
https://bugzilla.gnome.org/show_bug.cgi?id=733671
Matthias Clasen [Thu, 24 Jul 2014 12:29:12 +0000 (08:29 -0400)]
inspector: Show the buildable ID in the misc tab
This is useful, since you sometimes want to use it as #id in css.
Matthias Clasen [Thu, 24 Jul 2014 12:14:54 +0000 (08:14 -0400)]
inspector: Prepare misc tab for showing non-widgets
This will happen in the near future.
Ignacio Casal Quinteiro [Thu, 24 Jul 2014 06:34:02 +0000 (08:34 +0200)]
testtreemodel: fix unused variable on windows
Ignacio Casal Quinteiro [Wed, 23 Jul 2014 21:27:46 +0000 (23:27 +0200)]
win32: remove set but not used variables
Matthias Clasen [Wed, 23 Jul 2014 18:11:22 +0000 (14:11 -0400)]
GtkPlacesSidebar: Fix editing of bookmarks
This was silently broken - the code was just assuming that the
text cell renderer is item no. 6 on the list of all cells. That
doesn't work so well if the cell renderers are set up elsewhere
and get rearranged.
Fix this by keeping an explicit pointer to the the text cell.
Matthias Clasen [Wed, 23 Jul 2014 17:39:38 +0000 (13:39 -0400)]
GtkPathBar: Use symbolic icons
This fits better with the symbolic icons we use in the places
sidebar now.
Matthias Clasen [Wed, 23 Jul 2014 17:39:23 +0000 (13:39 -0400)]
GktFileSystem: Support rendering symbolic icons
Benjamin Otte [Wed, 23 Jul 2014 16:50:28 +0000 (18:50 +0200)]
reftest: Add reftest for CSS sizing fix
The test uses a GtkBox for rendering the background, but it could use
any other widget that is not used in the reference.
Benjamin Otte [Wed, 23 Jul 2014 16:40:55 +0000 (18:40 +0200)]
cssimage: Fix size computation for -gtk-icontheme()
For images without a concrete size but with an aspect ratio, we took the
wrong code path.
(I even copied the documentation that said "Otherwise" but didn't put an
else clause there, go me!)
Matthias Clasen [Wed, 23 Jul 2014 16:42:27 +0000 (12:42 -0400)]
GtkPathBar: Set style classes on buttons
Set text-button/image-button on these, just like we do for
buttons everywhere else.
Matthias Clasen [Wed, 23 Jul 2014 16:42:08 +0000 (12:42 -0400)]
GtkPathBar: Don't use GtkArrow
Instead, use an image button.
Lapo Calamandrei [Wed, 23 Jul 2014 15:53:31 +0000 (17:53 +0200)]
Adwaita: spinbutton button hover visible on the dark variant
Lapo Calamandrei [Wed, 23 Jul 2014 13:25:22 +0000 (15:25 +0200)]
Adwaita: entry icons position fix
Lapo Calamandrei [Wed, 23 Jul 2014 11:31:05 +0000 (13:31 +0200)]
Adwaita: backdrop check/radio fix
Set the correct color wrt the dark variant for checks/radios on
selected treeview rows.
Lapo Calamandrei [Wed, 23 Jul 2014 11:26:36 +0000 (13:26 +0200)]
Adwaita: GtkCalendar style simplification
Lapo Calamandrei [Wed, 23 Jul 2014 10:33:20 +0000 (12:33 +0200)]
Adwaita: accelerators
Ignacio Casal Quinteiro [Wed, 23 Jul 2014 08:43:41 +0000 (10:43 +0200)]
gtk-demo: include missing file on EXTRA_DIST
Matthias Clasen [Tue, 22 Jul 2014 22:50:31 +0000 (18:50 -0400)]
Add a test for matching with states
Matthias Clasen [Tue, 22 Jul 2014 22:32:02 +0000 (18:32 -0400)]
Add some tests for GtkAdjustment
Matthias Clasen [Tue, 22 Jul 2014 19:32:45 +0000 (15:32 -0400)]
widget-factory: Avoid a runtime warning
Don't set accelerators too early. GTK+ has not yet been initialized
at that point in main.
Lapo Calamandrei [Tue, 22 Jul 2014 18:26:43 +0000 (20:26 +0200)]
Adwaita: vertical spinbutton rtl fix
Lapo Calamandrei [Tue, 22 Jul 2014 18:21:30 +0000 (20:21 +0200)]
Adwaita: position needs-attention dot in rtl
Lapo Calamandrei [Tue, 22 Jul 2014 18:09:18 +0000 (20:09 +0200)]
Adwaita: correct color on insensitive check/radio labels
Lapo Calamandrei [Tue, 22 Jul 2014 18:02:06 +0000 (20:02 +0200)]
Adwaita: some more assets refresh
Lapo Calamandrei [Tue, 22 Jul 2014 17:50:15 +0000 (19:50 +0200)]
Adwaita: .needs-attention dark variant style
Lapo Calamandrei [Tue, 22 Jul 2014 17:13:34 +0000 (19:13 +0200)]
Adwaita: graphic assets refresh
Piotr Drąg [Tue, 22 Jul 2014 15:45:54 +0000 (17:45 +0200)]
Updated POTFILES.skip
Ignacio Casal Quinteiro [Tue, 22 Jul 2014 15:21:37 +0000 (17:21 +0200)]
gtkselection: fix warnings of unused vars on win32
Benjamin Otte [Tue, 22 Jul 2014 13:03:26 +0000 (15:03 +0200)]
scrolledwindow: Remove unused variable
Ignacio Casal Quinteiro [Tue, 22 Jul 2014 12:53:16 +0000 (14:53 +0200)]
win32: add css files to EXTRA_DIST
Lapo Calamandrei [Tue, 22 Jul 2014 12:33:44 +0000 (14:33 +0200)]
Adwaita: reduce padding on path bars
Carlos Garnacho [Tue, 22 Jul 2014 11:03:22 +0000 (13:03 +0200)]
treeview: Add back a check to ignore buttons > 3
The removal was not intentional, and still needed as the GtkGestureMultiPress
will work for any button unless told to lock on a single specific one.
Daniel Mustieles [Tue, 22 Jul 2014 10:33:12 +0000 (12:33 +0200)]
Updated Spanish translation
Lapo Calamandrei [Tue, 22 Jul 2014 08:29:01 +0000 (10:29 +0200)]
Adwaita: GtkSwitch in selected list rows